Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert user when Devfile is synced #6996

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Alert user when Devfile is synced #6996

merged 3 commits into from
Jul 21, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jul 21, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6902

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jul 21, 2023
@netlify
Copy link

netlify bot commented Jul 21, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 1acd6a8
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64ba56a7fbbc260008076eec

@feloy feloy requested a review from rm3l July 21, 2023 08:51
@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 7042dba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023 •
edited
Loading

NoCluster Tests on commit 7042dba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023 •
edited
Loading

Unit Tests on commit 7042dba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023 •
edited
Loading

Validate Tests on commit 7042dba finished successfully.
View logs: TXT HTML

@rm3l rm3l mentioned this pull request Jul 18, 2023
Closed
2 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023 •
edited
Loading

Kubernetes Tests on commit 7042dba finished successfully.
View logs: TXT HTML

rm3l
rm3l approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 21, 2023
@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 9605c92 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023 •
edited
Loading

Windows Tests (OCP) on commit 7042dba finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023 •
edited
Loading

OpenShift Tests on commit 7042dba finished successfully.
View logs: TXT HTML

@rm3l
Copy link
Member

rm3l commented Jul 21, 2023 

...
 [odo]  ✗  Syncing files into the container [675ms]
  [odo] Error occurred on Push - failed to sync to component with name kgvurx: unable to exec command [rm -rf /projects/*]
  [odo] === stderr===
  [odo] Error: open /home/runner/.local/share/containers/storage/overlay-containers/1c0f4be849bb123e7ad23f31ba407527fde70ef0c921b3d843ac2c53a625c133/userdata/2fc5439c619af38f6e9c1c096c8c078cfe482a96a0221a64f93fe7e1e769bf56/exit/1c0f4be849bb123e7ad23f31ba407527fde70ef0c921b3d843ac2c53a625c133: no such file or directory: exit status 255
...
Summarizing 1 Failure:
  [FAIL] odo dev command tests when java-springboot application is created and running odo dev when Update the devfile.yaml [It] Should build the application successfully [podman]
  /home/runner/work/odo/odo/tests/integration/cmd_dev_test.go:3241

Ran 191 of 958 Specs in 1560.583 seconds
FAIL! -- 190 Passed | 1 Failed | 0 Pending | 767 Skipped

Overriding because the changes here only affect the Dev UI.

/override ODO-PODMAN-TEST

@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2023

@rm3l: Overrode contexts on behalf of rm3l: ODO-PODMAN-TEST

In response to this:

...
[odo]  ✗  Syncing files into the container [675ms]
 [odo] Error occurred on Push - failed to sync to component with name kgvurx: unable to exec command [rm -rf /projects/*]
 [odo] === stderr===
 [odo] Error: open /home/runner/.local/share/containers/storage/overlay-containers/1c0f4be849bb123e7ad23f31ba407527fde70ef0c921b3d843ac2c53a625c133/userdata/2fc5439c619af38f6e9c1c096c8c078cfe482a96a0221a64f93fe7e1e769bf56/exit/1c0f4be849bb123e7ad23f31ba407527fde70ef0c921b3d843ac2c53a625c133: no such file or directory: exit status 255
...
Summarizing 1 Failure:
 [FAIL] odo dev command tests when java-springboot application is created and running odo dev when Update the devfile.yaml [It] Should build the application successfully [podman]
 /home/runner/work/odo/odo/tests/integration/cmd_dev_test.go:3241

Ran 191 of 958 Specs in 1560.583 seconds
FAIL! -- 190 Passed | 1 Failed | 0 Pending | 767 Skipped

Overriding because the changes here only affect the Dev UI.

/override ODO-PODMAN-TEST

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Jul 21, 2023 

 [odo] I0721 06:08:48.542878    1636 starterserver.go:102] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
 
...
Summarizing 1 Failure:
  [FAIL] odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag (custom api server port=false) [BeforeEach] should not describe the API Server in non-experimental mode
  C:/Users/Administrator.ANSIBLE-TEST-VS/4404/tests/helper/helper_run.go:50

Ran 390 of 956 Specs in 1255.392 seconds
FAIL! -- 389 Passed | 1 Failed | 0 Pending | 566 Skipped

Port conflict issue on Windows fixed recently with #6995.
Overriding because the changes here only affect the Dev UI.

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

[odo] I0721 06:08:48.542878    1636 starterserver.go:102] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.

...
Summarizing 1 Failure:
 [FAIL] odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag (custom api server port=false) [BeforeEach] should not describe the API Server in non-experimental mode
 C:/Users/Administrator.ANSIBLE-TEST-VS/4404/tests/helper/helper_run.go:50

Ran 390 of 956 Specs in 1255.392 seconds
FAIL! -- 389 Passed | 1 Failed | 0 Pending | 566 Skipped

Port conflict issue on Windows fixed recently with #6995.
Overriding because the changes here only affect the Dev UI.

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit fdafabe into redhat-developer:main Jul 21, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propagate changes from the local Devfile to the odo dev web UI
3 participants
@feloy @rm3l @openshift-merge-robot